bring controller to rt 0.20.1 and sdk 1.44.93 #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The S3 controller was not successfully being generated with ACK runtime v0.20.1. An error was being thrown during deepcopy-gen. Turns out that aws-sdk-go v1.44.93, which was brought in because it is used for latest code-generator, added a few fields to the S3 Bucket. One of these fields is `NotificationConfiguration.EventBridgeConfiguration` and it is an empty struct with no fields. Looks like S3 team just added it into the API model without finishing the thought... anyway, ignoring this field in the generator.yaml file enabled the code-generator to successfully complete. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The S3 controller was not successfully being generated with ACK
runtime v0.20.1. An error was being thrown during deepcopy-gen. Turns
out that aws-sdk-go v1.44.93, which was brought in because it is used for
latest code-generator, added a few fields to the S3 Bucket. One of these
fields is
NotificationConfiguration.EventBridgeConfigurationand it is anempty struct with no fields. Looks like S3 team just added it into the API
model without finishing the thought... anyway, ignoring this field in the
generator.yaml file enabled the code-generator to successfully complete.
Signed-off-by: Jay Pipes jaypipes@gmail.com
Issue aws-controllers-k8s/community#1475
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.