Invoke resolveCwd from package.json directory within require #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| this.options.require = (this.options.require || []).map(function (moduleId) { | ||
| var originalCwd = process.cwd(); | ||
| if (options.pkgDir) { | ||
| process.chdir(options.pkgDir); |
Member
There was a problem hiding this comment.
Using process.chdir is almost always a bad idea. It changes the CWD globally and can cause race issues and all kinds of problems. See: #985 (comment)
Member
| @novemberborn would be the best one to review this. |
novemberborn requested changes Sep 20, 2016
Member
novemberborn left a comment
novemberborn left a comment There was a problem hiding this comment.
@ltk will you have a chance to change the code to use resolve-from rather than chdir?
Author
| Yeah, I'll update this later today. Thanks for the suggestion! |
Member
| @ltk Friendly ping :) |
sindresorhus force-pushed the master branch 2 times, most recently from 4bc021e to 476c653 Compare Member
| Closing for lack of response. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #936
A variable
process.cwd()was problematic for the invocation ofresolveCwdon https://github.com/avajs/ava/compare/master...ltk:ltk/fix-936?expand=1#diff-2d5bbda346ebb54b9745d10f2fb5b1b6R37 when using the CLI from outside of the package.json directory.This PR normalizes the cwd to the pkgDir for every invocation.