Fix watcher test with Node 0.10 #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Neat, let's merge and update |
| - '[ -z "$COVERALLS_REPO_TOKEN" ] && tap --coverage-report=text-lcov | ./node_modules/.bin/coveralls' | ||
| matrix: | ||
| allow_failures: | ||
| - node_js: '0.10' |
Member
| get-stream@2 is out. |
Use the buffer variable in case only a partial line was received in the str. This was the original intent of this function.
In Node 0.10 pause() does not return the stream. The stream was being paused because get-stream did not use flowing mode, and adding the 'data' listener would switch the stream to flowing mode. However that did not work with Node 0.10 either. get-stream has been updated to use flowing mode, which makes pause() unnecessary. The test now passes in Node 0.10.
The watcher test is no longer failing. Hopefully using flowing mode in get-stream also fixes other random failures and we can require Node 0.10 tests to pass again.
novemberborn force-pushed the fix-010-watch-test branch from f065c47 to 7d0c6f3 Compare novemberborn added a commit that referenced this pull request Mar 3, 2016
Fix watcher test with Node 0.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #590. Depends on sindresorhus/get-stream#6. Hopefully fixes #498 as well.