Vue docs #1762
Merged
Vue docs #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
novemberborn requested changes Apr 7, 2018
docs/recipes/vue.md Outdated
| "require": [ | ||
| "./test/helpers/setup.js" | ||
| ] | ||
| "babel": "inherit" |
Member
There was a problem hiding this comment.
Did you intent to remove the "babel": "inherit" line, rather than the "require"` bit?
docs/recipes/vue.md Outdated
| ``` | ||
| | ||
| You can find more information about setting up Babel with AVA in the [babelrc recipe](babelrc.md). | ||
| You can find more information about setting up Babel with AVA in the [babelrc recipe](babel.md). |
Member
There was a problem hiding this comment.
Could you change this to "in the Babel recipe"?
BusbyActual commented Apr 7, 2018
Contributor Author
BusbyActual left a comment
BusbyActual left a comment There was a problem hiding this comment.
I did intend to remove babel inherit whoops! I also updated the doc reference
Member
| The PR needs a more descriptive title. |
sindresorhus reviewed Apr 8, 2018
docs/recipes/vue.md Outdated
| } | ||
| "require": [ | ||
| "./test/helpers/setup.js" | ||
| ] |
Member
There was a problem hiding this comment.
Incorrect indentation and missing a }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Progress #1662
As for the require library compatibility with Babel 7, there isn't any documentation confirming or denying. The require-extension-hooks-babel only has one file and it looks good to me.