Add --no-color flag - fixes #843

[thinkimlazy]

Disables color output with --no-color option for CLI and
"noColor": true for package.json
Resolves #843

[novemberborn]

@thinkimlazy thanks for your PR.

Reading #843 I can't determine whether @sindresorhus wanted this fixed in chalk, or whether he wanted a flag in AVA. Ideally this just works without needing additional options.

@sindresorhus?

[thinkimlazy]

@novemberborn Hey, thats not working ideally as you want because of this code in verbose/mini reporters:

chalk.enabled = true; Object.keys(colors).forEach(function (key) { colors[key].enabled = true; }); 

So when chalk initialized in reporters, --no-color really disables colors, but this loop enables them. So there is no need to fix anything in chalk.
Also we can delete this loops in reporters, then --no-color just works.

[snypelife]

Killing those forEach's in the reporters seems to work nicely, as well as clean things up a bit. But I noticed that env vars like CI or TEAMCITY_VERSION aren't getting picked up from https://github.com/chalk/supports-color/blob/master/index.js.

[snypelife]

@novemberborn from my perspective of that conversation in the issue, it looks like both a fix in the supports-color module as well as ava were sought after (ava being the flag needs to be passed down and supports-color needing teamcity <9 support).

[sindresorhus]

This will need a test of both the AVA output and chalk used in a test.

[sindresorhus]

This is incorrect. It should be:

cli.flags.color === false

[sindresorhus]

I think chalk.enabled = false should be enough.

[sindresorhus]

Actually. None of this should be needed as chalk already supports the --no-color flag.

[sindresorhus]

What actually needs to be done is to pass the flag down to the forked process.

[sindresorhus]

"color": false 

[sindresorhus]

@thinkimlazy Why did you close?

[thinkimlazy]

@sindresorhus sry, I messed up
I reopened PR

[sindresorhus]

@thinkimlazy You never have to open a new PR. That just creates noise in the issue tracker. You can always reset the state of an existing PR and start over if you really messed up.

[thinkimlazy]

@sindresorhus I can't reopen this one because I recreated my branch. Again sorry for spam

[sindresorhus]

No worries :)