Change StackElementFilter into an interface and add a Builder for common filters #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…mon filters These common filters are in preparation for introducing "stackhash" and the desire to make that easy to configure and perform well.
The StackHasher used includes all the common stack element filtering such that it should produce a relatively stable hash.
…om fields The evaluation uses system properties and environment variables to eval expressions in the form ${key} and ${key:defaultValue}. This also defaults the component in a K8s environment using the hostname. 
| I'm going to merge this and deploy it into a component. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These common filters are in preparation for introducing "stackhash" and the desire to make that easy to configure and perform well.