Fix typescript plugin with typescript 5 #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is done by tweaking the logic slightly (typescript 5 returns a slightly different AST tree) and also use the typescript util functions that are passed into the plugin. This is important because the vscode extension currently bundles a typescript version which might be different from the one that the project is using. And given that typescript relies on enums with numbers, we can run into issues where the value 357 for SyntaxKind might mean one thing in one version and something completely different in another typescript version.
laulauland approved these changes Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is done by tweaking the logic slightly (typescript 5 returns a slightly different AST tree) and also use the typescript util functions that are passed into the plugin. This is important because the vscode extension currently bundles a typescript version which might be different from the one that the project is using. And given that typescript relies on enums with numbers, we can run into issues where the value 357 for SyntaxKind might mean one thing in one version and something completely different in another typescript version.