Add fapi2 accounts endpoint #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Mainly this means creating a copy of the existing endpoint, changing the scope it uses (to one that has the fapi2 attribute) and adding DPoP support.
Now that Henrik has set the apache reverse proxy to include the X-Forwarded-Proto header and set the java-oauth-server container command line arguments to enable /usr/local/jetty/etc/jetty-http-forwarded.xml the http->https hack is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Mainly this means creating a copy of the existing endpoint, changing the scope it expects (to one that has the fapi2 attribute) and adding DPoP support (meaning both TLS certificate bound access tokens and DPoP proofs are acceptable for sender constraining the access token).