Skip to content

Conversation

@nebolsin
Copy link
Member

@nebolsin nebolsin commented Oct 14, 2023

Fixes #347.

  • update XDR definitions for protocol 20
  • implement contract representation in StrKey
  • InvokeHostFunction operation
  • BumpExpirationFootprint operation
  • RestoreFootprint operation
@coveralls-official
Copy link

coveralls-official bot commented Oct 14, 2023

Pull Request Test Coverage Report for Build 7606653998

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 87.694%

Totals Coverage Status
Change from base Build 7606647840: 2.6%
Covered Lines: 6615
Relevant Lines: 7466

💛 - Coveralls
@codacy-production
Copy link

codacy-production bot commented Oct 14, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+2.53% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7dbb97f) 6108 5257 86.07%
Head commit (cf22f80) 7466 (+1358) 6615 (+1358) 88.60% (+2.53%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#357) 45 45 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@nebolsin nebolsin force-pushed the protocol-20 branch 9 times, most recently from b283783 to 788b96d Compare October 17, 2023 03:39
* Rebase your local changes against the master branch. Resolve any conflicts that arise.
* Include a descriptive [commit message](https://github.com/erlang/otp/wiki/Writing-good-commit-messages).
* Changes contributed via pull request should focus on a single issue at a time.
* Rebase your local changes against the master branch. Resolve any conflicts that arise.

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when the spacing between a list item’s bullet and its content violates

[list-item-indent] Incorrect list-item indent: add 2 spaces
* Include a descriptive [commit message](https://github.com/erlang/otp/wiki/Writing-good-commit-messages).
* Changes contributed via pull request should focus on a single issue at a time.
* Rebase your local changes against the master branch. Resolve any conflicts that arise.
* Include a descriptive [commit message](https://github.com/erlang/otp/wiki/Writing-good-commit-messages).

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when the spacing between a list item’s bullet and its content violates

[list-item-indent] Incorrect list-item indent: add 2 spaces
* Changes contributed via pull request should focus on a single issue at a time.
* Rebase your local changes against the master branch. Resolve any conflicts that arise.
* Include a descriptive [commit message](https://github.com/erlang/otp/wiki/Writing-good-commit-messages).
* Changes contributed via pull request should focus on a single issue at a time.

Check notice

Code scanning / Remark-lint (reported by Codacy)

Warn when the spacing between a list item’s bullet and its content violates

[list-item-indent] Incorrect list-item indent: add 2 spaces
@nebolsin nebolsin force-pushed the protocol-20 branch 4 times, most recently from d114392 to 3c46fb9 Compare November 1, 2023 13:33
@nebolsin nebolsin linked an issue Jan 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants