Give _tkinter $ORIGIN-relative dependencies on glibc and an rpath on musl #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
geofft added platform:linux geofft added arch:x86_64 libc:musl build:noopt and removed arch:aarch64 python:3.13 labels 
| Giving up on testing this on musl for reasons noted in the comment, but the code to handle musl is there.... |
…musl Partially addresses astral-sh#742 and makes it consistent with what we're doing on macOS. There's an argument in the comments above that we should not set an rpath on libpython (except on musl where it's needed), and I need to see if I still believe that. In the meantime I'm following that pattern and setting $ORIGIN-relative NEEDED on glibc and rpath on musl only. This also adds a specific ldd regression test but not the additional tests listed in astral-sh#742.
This block was just added in astral-sh#676 and isn't actually Tcl/Tk-specific.
| Any word on this? I've run into it as well after upgrading from 3.12 to 3.13. I suspect it's only working "incidentally" at the moment as most systems already have tcl installed on the system. But not my dockerised test machines... |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Partially addresses #742 and makes it consistent with what we're doing on macOS.
There's an argument in the comments above that we should not set an rpath on libpython (except on musl where it's needed), and I need to see if I still believe that. In the meantime I'm following that pattern and setting $ORIGIN-relative NEEDED on glibc and rpath on musl only.
This also adds a specific ldd regression test but not the additional tests listed in #742.