Skip to content

Add 'from' method with JSR-310's type to DateValue and so on. #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Add 'from' method with JSR-310's type to DateValue and so on. #70

merged 1 commit into from
May 13, 2020

Conversation

@sciencesakura
Copy link
Contributor

@sciencesakura sciencesakura commented Apr 27, 2020

add:

  • DateValue from java.time.LocalDate

  • TimeValue from java.time.LocalTime

  • DateTimeValue from java.time.LocalDateTime
@sciencesakura
Copy link
Contributor Author

sciencesakura commented Apr 27, 2020

Oops, CI was failed...

It looks failed to authorize to analysis on SonarCloud. Would you please check it?
@VanRoy
Copy link
Member

VanRoy commented May 9, 2020

@sciencesakura Thanks a lot for your contribution. I will fix the CI quickly.
@VanRoy
Copy link
Member

VanRoy commented May 11, 2020

@sciencesakura Can you try to rebase from master, I pushed a fix on Sonar action.
@sciencesakura
Copy link
Contributor Author

sciencesakura commented May 12, 2020

It succeed.

@VanRoy thanks!
@VanRoy VanRoy added this to the 2.0.0 milestone May 13, 2020
@VanRoy VanRoy merged commit e126fb7 into assertj:master May 13, 2020
@VanRoy
Copy link
Member

VanRoy commented May 13, 2020

@sciencesakura Thanks for your contribution. Delivery planned for AssertJ-DB 2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement

2 participants

@sciencesakura @VanRoy