Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Conversation

@vlesierse
Copy link
Contributor

This PR should fix the CI by excluding the 1.0.0-beta3 and earlier because of the breaking changes.

@ghost ghost added the cla-already-signed label May 5, 2015
@vlesierse
Copy link
Contributor Author

The core clr image is failing at the moment....

System.TypeInitializationException: The type initializer for 'Microsoft.Framework.Runtime.Common.CommandLine.AnsiConsole' threw an exception. ---> System.PlatformNotSupportedException: This platform does not support getting the current color. at System.ConsolePal.get_ForegroundColor() at Microsoft.Framework.Runtime.Common.CommandLine.AnsiConsole..ctor(TextWriter writer) at Microsoft.Framework.Runtime.Common.CommandLine.AnsiConsole..cctor() --- End of inner exception stack trace --- at Microsoft.Framework.PackageManager.Program.CreateReports(Boolean verbose, Boolean quiet) at Microsoft.Framework.PackageManager.Program.<>c__DisplayClass3_1.<<Main>b__2>d.MoveNext() System.PlatformNotSupportedException: This platform does not support getting the current color. at System.ConsolePal.get_ForegroundColor() at Microsoft.Framework.Runtime.Common.CommandLine.AnsiConsole..ctor(TextWriter writer) at Microsoft.Framework.Runtime.Common.CommandLine.AnsiConsole..cctor() lxc-start: The container failed to start. lxc-start: Additional information can be obtained by setting the --logfile and --logpriority options. 
@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

@vlesierse Thanks for the PR. Looks like the that sample is not supposed to run on Linux. Is it the command line app sample? If so, I thought we don't run that (because we can't validate the same way). If not, I can't see why Ansi color is required in a web app. I'll look more once I'm on desktop.

@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

@vlesierse it looks like dnu restore is just failing on Linux. Can you please report this to aspnet/dnu? I can see 1.0.0-beta4 is passing the tests fine so I think we may do another grep -v 'coreclr-1.0.0-beta5-11624' for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion: maybe another -d ... and else would fail with an error message?

@vlesierse
Copy link
Contributor Author

I'll make the changes and post an issue in the aspnet/dnu. Maybe an option like --no-color could be enough. I understand that this is due to a limitation within the core clr.

@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

@vlesierse yep looks like that's just not implemented in PAL b/c ANSI terminals have no default font color or bg color like windows consoles. However, dnu restore crashing on linux for that reason is certainly not good.

@Eilon Eilon closed this May 5, 2015
@Eilon Eilon reopened this May 5, 2015
@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

@Eilon why is cla required again for him? What's going on here?

@Eilon
Copy link
Contributor

Eilon commented May 5, 2015

We just changed the repos from MS Open Tech to .NET Foundation so there's a different CLA. The new CLA is simpler than the old one and so should only take a few moments to re-sign. Apologies for the extra bit of work!

@vlesierse
Copy link
Contributor Author

Ok, signed the CLA on https://cla.dotnetfoundation.org

@Eilon
Copy link
Contributor

Eilon commented May 5, 2015

Thanks @vlesierse !

@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

LGTM. Thanks.

ahmetb added a commit that referenced this pull request May 5, 2015
Fixed CI tests by excluding 1.0.0-beta3 and earlier
@ahmetb ahmetb merged commit 2011dda into aspnet:master May 5, 2015
@ahmetb ahmetb mentioned this pull request May 5, 2015
@ahmetb
Copy link
Contributor

ahmetb commented May 5, 2015

BTW I realized ANSI color issue with dnu is tracked at various places:

aspnet/dnx#1768
aspnet/dnx#1708
dotnet/aspnetcore#559
aspnet/dnx#1751
aspnet/dnx#1724
https://github.com/dotnet/coreclr/issues/882
aspnet/dnx#1724

It's the right call to keep it out of CI for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

4 participants