Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Conversation

@yanchenw
Copy link
Contributor

@yanchenw yanchenw commented May 4, 2015

Use mono 4.0.1 instead of mono 4.1.0 as aspnet/home suggested:
https://github.com/aspnet/Home/blob/dev/GettingStartedDeb.md

Change vs-1.0.0-beta4 to based on official aspnet:1.0.0-beta4 to keep them consistent.

@ghost
Copy link

ghost commented May 4, 2015

Hi @yanchenw, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label May 4, 2015
@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

@yanchenw thanks for the PR! I will hold off until this PR until mono:4.1.0 is tagged on Docker Hub if there's no urgent need?

@yanchenw
Copy link
Contributor Author

yanchenw commented May 4, 2015

Should be OK. Any idea when mono 4.1.0 will be tagged?

@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

@yanchenw nope but once it appears at https://github.com/mono/mono/tags it'll probably take a day or so.

@akoeplinger
Copy link

Mono 4.1 (like all odd subversions) is the "in development" version and typically won't receive a tag.

@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

@akoeplinger Oh, I didn't know that convention. It is apparently case with mono Docker images as well: https://registry.hub.docker.com/u/library/mono/

I guess we could still use 4.1.0 release by doing apt-get install mono from Mono's repositories? In that case, this PR seems like the only solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no need for this folder anymore.

I will make this point to 1.0.0-beta4 folder on Docker Hub settings once merged and 1.0.0-beta4 and vs-1.0.0-beta4 will be the same image that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@akoeplinger
Copy link

I guess we could still use 4.1.0 release by doing apt-get install mono from Mono's repositories?

4.1 will never be in the repositories, it'll be declared 4.2 once it's "stable".

@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

@akoeplinger ok I was deceived by the apt-get install mono-complete @yanchenw does in the beta4 dockerfile... There's a mono:4.0.1, why don't we just use that if we're switching to 4.0.1?

according to aspnet/home, remove vs-1.0.0-beta4 since it should points to official 1.0.0-beta4 image now.
@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

@yanchenw thanks for the change. Merging assuming you tested the product that uses the vs-* image.

@ahmetb
Copy link
Contributor

ahmetb commented May 4, 2015

Waiving CLA since @yanchenw is a MSFT employee (he's registering himself to the CLA system now).

ahmetb added a commit that referenced this pull request May 4, 2015
Use mono 4.0.1 instead of mono 4.1.0 in beta4
@ahmetb ahmetb merged commit 1dd17e8 into aspnet:master May 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants