Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Update to .NET Core 1.0.10, 1.1.8, and 2.0.6 #387

Merged
merged 3 commits into from
Mar 14, 2018
Merged

Update to .NET Core 1.0.10, 1.1.8, and 2.0.6 #387

merged 3 commits into from
Mar 14, 2018

Conversation

natemcmaster
Copy link
Contributor

Changes:

  • Update bundled .NET Core runtime to 1.0.10, 1.1.8, and 2.0.6
  • Update SDK to 2.1.101
  • Add new tags for these new runtimes and update <major>.<minor> tags for the patch updates

Heads up: CI is expected to fail until dotnet/dotnet-docker#422 is completed.
MichaelSimons
MichaelSimons reviewed Mar 13, 2018
View reviewed changes
README.aspnetcore.md Outdated

- [`1.0.9-jessie`, `1.0.9`, `1.0` (*1.0/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.0/jessie/runtime/Dockerfile)
- [`1.0.10-jessie`, `1.0.10`, `1.0` (*1.0/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.0/jessie/runtime/Dockerfile)
- [`1.1.6-jessie`, `1.1.6`, `1.1`, `1` (*1.1/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.1/jessie/runtime/Dockerfile)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see a version rev for the two 1.1.* images.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes this should bump.
MichaelSimons
MichaelSimons approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending availability of base images.
@natemcmaster
Copy link
Contributor Author

@dotnet-bot test ci please
@MichaelSimons
Copy link
Contributor

FYI not all images are available yet.
@MichaelSimons
Copy link
Contributor

@dotnet-bot test ci please
@MichaelSimons
Copy link
Contributor

Hmm, maybe I don't have the magic powers to kick CI. Regardless the microsoft/dotnet images are available now.
@natemcmaster
Copy link
Contributor Author

@dotnet-bot test Windows SAC2016 2.0/nanoserver-sac2016 Build
@dotnet-bot test Windows SAC2016 1 Build
@dotnet-bot test Windows 1709 2.0/nanoserver-1709 Build
@dotnet-bot test Linux 2.0 Build
@dotnet-bot test Linux 1 Build
@natemcmaster
Copy link
Contributor Author

For some reason, the "dotnet-bot test ci please" comment isn't triggering all builds. @mmitche any ideas?
@MichaelSimons
Copy link
Contributor

I just realized it was the wrong cmd. You want to say dotnet-bot test please. dotnet-bot test ci please is what triggers the Gen CI job.
@natemcmaster
Copy link
Contributor Author

Ah, that makes more sense. Didn't realize there was a difference.
muratg
muratg approved these changes Mar 13, 2018
View reviewed changes
Copy link

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@natemcmaster
Copy link
Contributor Author

@dotnet-bot test Windows 1709 2.0/nanoserver-1709 Build
@dotnet-bot test Windows SAC2016 2.0/nanoserver-sac2016 Build
@natemcmaster
Copy link
Contributor Author

@dotnet-bot test Windows SAC2016 1 Build
@natemcmaster natemcmaster merged commit 7823cc2 into aspnet:master Mar 14, 2018
@natemcmaster natemcmaster deleted the march-patch branch March 14, 2018 00:48
@natemcmaster natemcmaster mentioned this pull request Mar 23, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@natemcmaster @MichaelSimons @muratg