This repository was archived by the owner on May 31, 2019. It is now read-only.
Refactor tests to use multi-stage builds #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MichaelSimons approved these changes Mar 7, 2018
test.ps1 Outdated
| finally { | ||
| exec docker volume rm $app_volume_name | ||
| } | ||
| $app_tagname = "$app_name-self-contained" |
There was a problem hiding this comment.
Consider factoring out the commonality between the self-contained and framework-dependent tests. The pattern seems identical outside of a couple build args and Dockerfile to build.
There was a problem hiding this comment.
I'll look into it. I ran into some odd issues with caching in Windows. Possibly a docker bug.
MichaelSimons approved these changes Mar 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #330
This should fix some errors we are having on CI with mounted volumes and Windows permissions. cref #378