Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Conversation

@mattva01
Copy link

This may increase build times (unless the two apt-get blocks are merged), but it should significantly reduce the end image size.

@ghost
Copy link

ghost commented Feb 14, 2015

Hi @mattva01, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label Feb 14, 2015
@ghost
Copy link

ghost commented Feb 14, 2015

@mattva01, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSOTBOT;

@ghost ghost added cla-signed and removed cla-required labels Feb 14, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Feb 14, 2015

@Eilon for some reason PR is not built with CI? Can you please check CircleCI still appears in repo settings?

@mattva01 how much does this actually reduce the image size? can you please provide a before/after comparison?

@mattva01
Copy link
Author

@ahmetalpbalkan It's weird, it only saves around 20 megs. it should be more
mattva01/aspnet latest 4cda43d5195b 32 minutes ago 460.2 MB
microsoft/aspnet latest 6d21a65194aa 39 hours ago 479.4 MB

It's still a good practice though, especially since images are designed to inherit from it.

@mattva01
Copy link
Author

Oh, it's because upstream is debian I think and not a more bare repo.

Also, if you do want to merge this, I should probably remove the "-qq" from the first "apt-get update". It passes the tests on my circleci(https://circleci.com/gh/mattva01/aspnet-docker/1), but probably better to have that be verbose for debugging purposes.

@ahmetb
Copy link
Contributor

ahmetb commented Feb 14, 2015

@mattva01 I think we are just fine as is. We will be transitioning to official .NET implementation soon and mono will go away. I expect package size to decrease a lot and I prefer simplicity in Dockerfile for 20 MB. 😄 Thanks, though.

@mattva01
Copy link
Author

Haha, no problem. Do remember this trick for your future builds though. A lot of folks forget about it and in some cases it can save hundreds of megs.

@mattva01 mattva01 closed this Feb 14, 2015
@Eilon
Copy link
Contributor

Eilon commented Feb 15, 2015

@ahmetalpbalkan I just enabled the feature to auto-build PRs from forks.

@ahmetb
Copy link
Contributor

ahmetb commented Feb 15, 2015

@Eilon ah thanks, I forgot to mention that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants