Update 1.x runtime images to the latest 1.x patch and stop producing a 1.0 sdk image #329
Conversation
….x image from aspnetcore-build
| <TargetFramework>netcoreapp1.1</TargetFramework> | ||
| <RuntimeIdentifiers>win7-x64</RuntimeIdentifiers> | ||
| <TargetFrameworks>netcoreapp1.0;netcoreapp1.1</TargetFrameworks> | ||
| <RuntimeIdentifiers>debian.8-x64</RuntimeIdentifiers> |
There was a problem hiding this comment.
copy-pasta. will fix
| <PackageReference Include="Microsoft.Net.Http.Headers" Version="1.0.4" /> | ||
| <PackageReference Include="Microsoft.Net.Http.Server" Version="1.0.5" /> | ||
| <PackageReference Include="Microsoft.Net.WebSockets.Server" Version="0.1.0" /> | ||
| <PackageReference Include="Microsoft.NETCore.App" Version="1.0.7" /> |
There was a problem hiding this comment.
It's okay to remove these?
There was a problem hiding this comment.
they're implicit in the SDK
| "sharedTags": { | ||
| "1.1.4": {}, | ||
| "1.1": {}, | ||
| "1": {} |
There was a problem hiding this comment.
What are these new tags?
There was a problem hiding this comment.
Not new, just moved here as a part of condensing our duplicate SDK images.
…cache restore warmup
…ackage-cache restore warmup
natemcmaster changed the title | It seemed odd to only update half of the 1.x update. Updated this PR to also bump the 1.1 images to latest runtime. The package versions are still not updated...pending resolution of the bad MVC packages issues. |
manifest.json Outdated
| }, | ||
| "1.0.7-nanoserver-$(nanoServerVersion)": { | ||
| "1.0.8-nanoserver-sac2016": {}, | ||
| "1.0.8-nanoserver": { |
There was a problem hiding this comment.
I think the undocumented tags like this should be dropped during this service event instead of rev'ing the version. The reason they exist was to preserve backwards compatibility when we introduced the multi-arch tags.
There was a problem hiding this comment.
Would you include 2.0.3-nanoserver in that? It was an undocumented tag that was rev-ed in #328. We could manually drop it from docker hub and remove it during this PR
There was a problem hiding this comment.
Yes those tags could also be removed. I think at this point waiting until the next release would be the correct process to follow.
… the broken MVC packages
| 🆙 📅 ready for final review |
| To make sure I am following, when ASP.NET addressed the bad MVC packages, the Docker image tags will be rev'd? (edit) to clarify I am referring to the 1.1 images. |
README.aspnetcore.md Outdated
| | ||
| - [`1.0.7-jessie`, `1.0.7`, `1.0`, `lts` (*1.0/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.0/jessie/runtime/Dockerfile) | ||
| - [`1.0.8-jessie`, `1.0.8`, `1.0` (*1.0/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.0/jessie/runtime/Dockerfile) | ||
| - [`1.1.4-jessie`, `1.1.4`, `1.1`, `1` (*1.1/jessie/runtime/Dockerfile*)](https://github.com/aspnet/aspnet-docker/blob/master/1.1/jessie/runtime/Dockerfile) |
There was a problem hiding this comment.
Shouldn't the readmes be updated with the 1.1.5 tags?
There was a problem hiding this comment.
Good catch. updated.
JunTaoLuo left a comment
JunTaoLuo left a comment There was a problem hiding this comment.
I took a look at the version numbers and I'd like to think that we need to updated the weblistnener versions. This means 1.0.6 and 1.1.4 for the 1.x branches.
These fixes were "package only" which mean it was never put into any downstream assets like the LZMA or the package cache. However, these packages were updated on nuget so I think we can update them here.
| @MichaelSimons Correct, we will build 1.1.6 images. |
MichaelSimons left a comment
MichaelSimons left a comment There was a problem hiding this comment.
The Dockerfiles, manifest, and readme look good. I'll let John cover the packages aspect.
| @JunTaoLuo I updated the weblistener packages |
| Thanks @natemcmaster! |
3 participants
Microsoft/dotnet no longer produces a 1.0-sdk image as it was identical with 1.1-sdk. Likewise, this changes "microsoft/aspnetcore-build:1.0" to be an undocumented tag that is an alias of microsoft/aspnetcore-build:1.1