Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Conversation

@glennc
Copy link
Member

@glennc glennc commented Oct 15, 2015

Beta 8 Dockerfiles

@glennc
Copy link
Member Author

glennc commented Oct 15, 2015

@ahmetalpbalkan @anurse give me a shipit on this one?

@ahmetb
Copy link
Contributor

ahmetb commented Oct 15, 2015

CI 🍏 = :shipit:.

but I don't think we should have these trailing commas. no idea how they got in there in the first place.

image

@glennc
Copy link
Member Author

glennc commented Oct 15, 2015

Yeah, I was just copying what was there before. I will do another PR to get rid of them after this one.

glennc added a commit that referenced this pull request Oct 15, 2015
@glennc glennc merged commit 9ec3279 into master Oct 15, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Oct 15, 2015

#:100: :confetti_ball:

@ahmetb
Copy link
Contributor

ahmetb commented Oct 15, 2015

@glennc next time can you use your fork as PR branch? Every time you push commit to here (any branch) Docker Hub triggers a build.

@glennc
Copy link
Member Author

glennc commented Oct 15, 2015

Sure thing.

@glennc glennc deleted the glennc/beta8 branch December 1, 2015 19:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

4 participants