This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Do not fallback to creating console logger #1789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pranavkm approved these changes Nov 13, 2018
| Please log an announcement for this. I can't tell how big a breaking change it will be for some people. Please include the new code someone would have to use if they still want to have console logging. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Falling back to creating instances of console logger is bad practice. Each of them would create a new writing thread and background queue. In addition, ConsoleLogger type is becoming private.
cc @Eilon
Technically it's a breaking change for customers who didn't have logging configured at all and used JavaScriptServices.