This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Add Id to ConnectionInfo #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
khellang force-pushed the connection-trace-identifier branch 2 times, most recently from 4a59d94 to e8a8e4d Compare 
davidfowl reviewed Apr 25, 2017
| private FeatureReferences<FeatureInterfaces> _features; | ||
| | ||
| public DefaultConnectionInfo(IFeatureCollection features) | ||
| { |
Contributor Author
There was a problem hiding this comment.
Yes, it is. I thought it made sense to clean it up when touching the file anyway. I can strip e8a8e4d if you want...
khellang force-pushed the connection-trace-identifier branch from e8a8e4d to 00e9bc8 Compare khellang force-pushed the connection-trace-identifier branch from 00e9bc8 to a38a527 Compare 
Tratcher reviewed Apr 25, 2017
| /// <summary> | ||
| /// Gets or sets a unique identifier to represent this connection in trace logs. | ||
| /// </summary> | ||
| public abstract string TraceIdentifier { get; set; } |
Member
There was a problem hiding this comment.
👎 this is mixing names. We already have a TraceIdentifier on HttpContext with a different source value (actually made for tracing). Just call it ConnectionId
Contributor Author
There was a problem hiding this comment.
So... HttpContext.Connection.ConnectionId? Smurf much? 😉
Contributor Author
There was a problem hiding this comment.
Sure, that was next on my list after TraceIdentifier 😄
Tratcher approved these changes Apr 25, 2017
khellang changed the title 
Contributor Author
| ❤️ |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Take it or leave it 😉 I went with
TraceIdentifierto match the request ID onHttpContext.Closes #827