Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Added sample to demonstrate rendering view to a string #85

Merged
ajaybhargavb merged 1 commit into from
Jan 21, 2016
Merged

Added sample to demonstrate rendering view to a string #85

ajaybhargavb merged 1 commit into from
Jan 21, 2016

Conversation

@ajaybhargavb
Copy link
Contributor

@ajaybhargavb ajaybhargavb commented Jan 13, 2016

@dnfclas
Copy link

dnfclas commented Jan 13, 2016

Hi @ajaybhargavb, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;
dougbu
dougbu reviewed Jan 13, 2016
View reviewed changes
samples/Mvc.RenderViewToString/EmailGraphHelper.cs Outdated
Copy link
Contributor

@dougbu dougbu Jan 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rynowak how many negative #AllRyans points is naming this a BlahHelper worth?
Copy link
Member

@rynowak rynowak Jan 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the points I had out are always negative.
Copy link
Member

@rynowak rynowak Jan 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta-question: what is this class intending to demonstrate? What's it a surrogate for in a 'real' application?
Copy link
Contributor Author

@ajaybhargavb ajaybhargavb Jan 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply present to demonstrate @inject.
Copy link
Contributor

@dougbu dougbu Jan 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simply present to demonstrate @inject.

I'm struggling with this because views make extensive use of the @inject infrastructure without users entering the keyword. Suggest the sample would be clearer without this.

If it stays, would prefer new names for this and RazorViewHelper.
@dougbu
Copy link
Contributor

dougbu commented Jan 13, 2016

⌚ (like the overall approach)
rynowak
rynowak reviewed Jan 13, 2016
View reviewed changes
samples/Mvc.RenderViewToString/Program.cs Outdated
Copy link
Member

@rynowak rynowak Jan 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think path here requires a little more fanfare for a reader to understand exactly what this does.
@ajaybhargavb
Copy link
Contributor Author

ajaybhargavb commented Jan 14, 2016

Updated.
@dougbu
Copy link
Contributor

dougbu commented Jan 14, 2016

⌚
@ajaybhargavb
Copy link
Contributor Author

ajaybhargavb commented Jan 15, 2016

Updated.
@dougbu
Copy link
Contributor

dougbu commented Jan 15, 2016

:shipit:
@ajaybhargavb ajaybhargavb merged commit 9fbc09f into dev Jan 21, 2016
@ajaybhargavb ajaybhargavb deleted the view-to-string branch January 21, 2016 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-already-signed

7 participants

@ajaybhargavb @dnfclas @dougbu @pranavkm @Eilon @rynowak