[WIP] URL Rewrite - Implementing mod_rewrite #149
Conversation
… redirect, the other with rule type first
…ure. Hopefully can just do a string replace on it
…clean up code, and implement all flags in the near future
| Hi @ZestyBread, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| Shouldn't this be in BasicMiddleware? |
| @@ -0,0 +1,15 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Copyright (on all files, no just this one)
| public static class RewriteConfigurationExtensions | ||
| { | ||
| | ||
| public static List<Rule> AddRewriteFile(string path) |
There was a problem hiding this comment.
The class is called extensions but this is not an extension method
| ⌚ |
| { | ||
| public List<ConditionTestStringSegment> TestStringSegments { get; } | ||
| public GeneralExpression ConditionRegex { get; } | ||
| public List<string> Flags { get; } |
There was a problem hiding this comment.
Nice but List is still mutable. Make it IEnumerable
…ed condition to final condition
| public Operand Operand { get; set; } | ||
| public bool Invert { get; set; } | ||
| | ||
| public bool VisitConditionExpression(HttpContext context, Match results, Match previous, string concatTestString) |
There was a problem hiding this comment.
this should not be a method on the expression. the visitor with all the methods is a separate class. The base visitor has has all the methods virtual and they simply go throught the graph. That way, you can implement your own visitor by overiding parts of the original visitor without having the implement everything and it also allows you to stop the visitor if you don't need to visit the child of one node
| Moving this to Basic Middleware! |
Barebones implementation of mod_rewrite. Can handle only simple replacement rules for now. Majority of the work remains in implementing the flags, which provide the power to do redirects, different portions of the context, etc.
This is here mostly for a review tomorrow, but feel free to comment on major aspects (we'll handle nits once we are much closer to pushing this).
@Tratcher @muratg @victorhurdugaci @davidfowl @DamianEdwards