Fix MvcRenderViewToString and add a test to verify it works #147
Conversation
| Hi @pranavkm, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| cc @dougbu \ @ajaybhargavb |
| options.FileProviders.Add(new PhysicalFileProvider(customApplicationBasePath ?? applicationEnvironment.ApplicationBasePath)); | ||
| options.FileProviders.Add(fileProvider); | ||
| }); | ||
| var diagnosticSource = new DiagnosticListener("Microsoft.AspNetCore"); |
There was a problem hiding this comment.
How would you prefer hosting-provided services be handled?
There was a problem hiding this comment.
Since Razor depends on it and we sort of expect it to work in non-hosted scenarios, we should add it as part of AddRazor \ AddMvc. It's a no-op operation if it already exists via Hosting.
| | ||
| namespace EntropyTests | ||
| { | ||
| public static class RazorEmbeddedResource |
There was a problem hiding this comment.
Any changes from the TagHelperSampleTest source?
There was a problem hiding this comment.
The method was made public and it's referencing this type to locate the project, but nothing apart from that.
| LGTM but I defer to @ajaybhargavb on the squirrel. |
| Ping @ajaybhargavb |
|
|
| Does it make sense to add one more test with |
| It's kinda tricky because you have to in some way modify the |
| Got it |
No description provided.