Added new sample Mvc.FileUpload #123
Conversation
| Hi @kichalla, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| <RootNamespace>Microsoft.Extensions.Configuration.ConfigFile</RootNamespace> | ||
| <BaseIntermediateOutputPath Condition="'$(BaseIntermediateOutputPath)'=='' ">..\..\artifacts\obj\$(MSBuildProjectName)</BaseIntermediateOutputPath> | ||
| <OutputPath Condition="'$(OutputPath)'=='' ">..\..\artifacts\bin\$(MSBuildProjectName)\</OutputPath> | ||
| <OutputPath Condition="'$(OutputPath)'=='' ">..\..\artifacts\</OutputPath> |
There was a problem hiding this comment.
This was changed by the latest (the last recommended) tooling. I will revert it.
There was a problem hiding this comment.
Please don't fight the tools. It's going to do this every time you open the solution
kichalla force-pushed the kiran/restrictive-fileupload branch 2 times, most recently from 6897551 to 3ba719f Compare kichalla changed the title kichalla changed the title kichalla force-pushed the kiran/restrictive-fileupload branch 2 times, most recently from 35eb045 to 0eda7e9 Compare 
| 🆙 📅 |
| "LogLevel": { | ||
| "Default": "Debug", | ||
| "System": "Information", | ||
| "Microsoft": "Debug" |
There was a problem hiding this comment.
Will revert to the default Information level
| 🆙 📅 |
| 👍 |
| //await cloudBlockBlob.UploadFromStreamAsync(section.Body); | ||
| | ||
| //targetFilePath = blobId; | ||
| //_logger.LogInformation($"Copied the uploaded file '{fileName}' to blob with id '{blobId}'."); |
There was a problem hiding this comment.
I don't think there's any value to having this code here. This just bloats the sample - if we need to provide a sample for blob storage let's do that separately.
| Looks like https://github.com/aspnet/Entropy/pull/123/files#r64093232 still needs to be addressed other than that |
from me
| | ||
| // Get the default form options so that we can use them to set the default limits for | ||
| // request body data | ||
| private static readonly FormOptions _defaultFormOptions = new FormOptions(); |
There was a problem hiding this comment.
In this sample request form is being parsed manually (in the sense that MultipartReader is being used to read individual parts and handled) compared to depending on FormFeature. Most of the code here is borrowed from FormFeature and I wanted to use the default limits here too.
kichalla force-pushed the kiran/restrictive-fileupload branch from 5cd75de to 6b74a20 Compare | 🆙 📅 @Tratcher I updated the PR with appwide FormOptions settings |
|
|
@rynowak @Tratcher