Update test SDK and xunit version #526
Conversation
| <NETStandardImplicitPackageVersion>$(BundledNETStandardPackageVersion)</NETStandardImplicitPackageVersion> | ||
| <TestSdkVersion>15.0.0</TestSdkVersion> | ||
| <XunitVersion>2.2.0</XunitVersion> | ||
| <TestSdkVersion>15.3.0-*</TestSdkVersion> |
There was a problem hiding this comment.
Should these use exact versions? Or is it safe to let them float? I kind of prefer exact versions because it makes sure no one will pull a switcheroo on us and then our build breaks.
(Same goes for xUnit version.)
There was a problem hiding this comment.
I think it's safe to float. Here's my thinking:
Floating xunit: the next update to NuGet would be 2.3.0-beta3-* so we won't get automatically lifted off beta2. Also, I used floating this a matter of convenience because the full version of xunit and xunit.runner.visualstudio differ slightly by their build numbers.
Floating Microsoft.NET.Test.Sdk to 15.3.0-* should also be ok. We mirror Microsoft.NET.Test.Sdk in our gatekeeper build, so the version on aspnetcore-ci-dev is ahead of the version on nuget.org. As new nightlies roll in, our gatekeeper build should catch issues before they make it to nuget.org. (hopefully)
| </ItemGroup> | ||
| | ||
| <ItemGroup> | ||
| <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> |
There was a problem hiding this comment.
FYI - should no longer be added automatically when using VS 15.3.0 preview. :)
natemcmaster force-pushed the namc/test-up branch from bfd0190 to 3f65142 Compare 
Update to Microsoft.NET.Test.Sdk 15.3.0 and xunit 2.3.0-beta2.
Cleanup a duplicate test (thanks to better xunit diagnostics in xunit 2.3 :) )
cref https://github.com/aspnet/Coherence-Signed/issues/49
cc @Eilon - OSS approval for new xunit version