Make ServiceProvider public #510
Conversation
- Make ServiceProvider public so that it can be returned from BuildServiceProvider(). - Make it sealed since it can't really be extended. - Changed tests to stop down casting.
| /// The default IServiceProvider. | ||
| /// </summary> | ||
| internal class ServiceProvider : IServiceProvider, IDisposable | ||
| public sealed class ServiceProvider : IServiceProvider, IDisposable |
There was a problem hiding this comment.
I know it's evil but @benaadams will be happy
There was a problem hiding this comment.
Aren't any virtual calls; might as well make it non-sealed? (Then people can extend/enhance in a non-interfering way)
There was a problem hiding this comment.
The other reason I made it sealed is to avoid things like #476
There was a problem hiding this comment.
And people can always wrap.
There was a problem hiding this comment.
Can't add extra data to the type and then use an as cast to surface it with a wrap...
| "OldMemberId": "public static System.IServiceProvider BuildServiceProvider(this Microsoft.Extensions.DependencyInjection.IServiceCollection services)", | ||
| "NewTypeId": "public static class Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions", | ||
| "NewMemberId": "public static Microsoft.Extensions.DependencyInjection.ServiceProvider BuildServiceProvider(this Microsoft.Extensions.DependencyInjection.IServiceCollection services)", | ||
| "Kind": "Modification" |
There was a problem hiding this comment.
FYI API Check doesn't actually care much about additions to regular classes and it has a bug when handling Modification exceptions in interfaces (aspnet/BuildTools#154). Might as well make this a Removal and leave out the New* properties.
There was a problem hiding this comment.
When the tool spits out what it wants me to write I'll do that. It took me way too long to figure this out.
| 👍 |
| @davidfowl Will hosting continue to call (_applicationServices as IDisposable)?.Dispose();, or will it only dispose |
| It needs to keep doing that to support other service providers. |
from BuildServiceProvider().
#338