Skip to content
This repository was archived by the owner on Nov 2, 2018. It is now read-only.

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Mar 11, 2017

  • Added a benchmark project (using benchmark.NET)
  • Copied most of the infrastructure from kestrel and tweaked it a little
  • Added a resolve benchmark
Method Mean StdErr StdDev Scaled Scaled-StdDev RPS Gen 0 Allocated
NoDI 6.9489 ns 0.1808 ns 0.9905 ns 1.00 0.00 143,906,789.32 0.0112 24 B
Transient 51.2131 ns 0.3905 ns 2.1389 ns 7.47 0.82 19,526,255.52 0.0091 24 B
Scoped 106.3770 ns 4.2441 ns 23.2460 ns 15.53 3.71 9,400,532.68 - 0 B
Singleton 123.1784 ns 3.6458 ns 19.9689 ns 17.98 3.42 8,118,307.04 - 0 B
@khellang
Copy link
Contributor

Does RPS bring any value here?

@davidfowl
Copy link
Member Author

@khellang That's a good question. I like those big numbers 😄

@benaadams
Copy link
Contributor

Does RPS bring any value here?

Its easier to evaluate than 0.0001 ns

@benaadams
Copy link
Contributor

Quite fast... might need to stick it in a loop to be accurate :)

@pakrym
Copy link
Contributor

pakrym commented Mar 11, 2017

I don't like copying same code around, would prefer having package with benchmark.net specific code

@davidfowl
Copy link
Member Author

davidfowl commented Mar 11, 2017

I don't like copying same code around, would prefer having package with benchmark.net specific code

I knew you were going to say that. Will postpone this until then.

Also which thing do you want to be common between the repos? The config here is different. I can get rid of the RPS column, that's a shared component we can have. With the inner loops, the time is usable.

@pakrym
Copy link
Contributor

pakrym commented Mar 11, 2017

Program.cs code can be shared too

@davidfowl
Copy link
Member Author

Like 5% of the code, the enum (which is a hack) isn't sharable. It really needs to be based on type names, not an enum.

@pakrym
Copy link
Contributor

pakrym commented Mar 11, 2017

We need to make it type based not enum based anyway, so it would be 100%

@davidfowl
Copy link
Member Author

It needs to be rewritten is my point. Anyways, I'll add a package to Common with those 2 shared functions.

@davidfowl
Copy link
Member Author

@davidfowl
Copy link
Member Author

@AresPr yes, see #490

@pakrym
Copy link
Contributor

pakrym commented Mar 11, 2017

@davidfowl do we want to contribute RPS column to BDN?

@davidfowl
Copy link
Member Author

@pakrym Yes, I was just asking @benaadams if he wrote it. It really belongs there.

@benaadams
Copy link
Contributor

RPS came from @mattwarren

@davidfowl davidfowl merged commit 831ad48 into dev Mar 12, 2017
@davidfowl davidfowl deleted the davidfowl/benchmarks branch August 22, 2018 07:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

7 participants