Update to VS 2017 #479
Update to VS 2017 #479
Conversation
natemcmaster left a comment
natemcmaster left a comment There was a problem hiding this comment.
Also, add os: Visual Studio 2017 RC to appveyor.yml. Just noticed net451 tests aren't running with the Windows-only net451. Will fix that soon.
build/common.props Outdated
| | ||
| <PropertyGroup> | ||
| <Product>Microsoft .NET Extensions</Product> | ||
| <RepositoryUrl>https://github.com/aspnet/Razor</RepositoryUrl> |
| VisualStudioVersion = 14.0.23107.0 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{D26F6F80-63EE-4081-A814-EF3DBABE24D9}" | ||
| EndProject |
There was a problem hiding this comment.
Also update lines with Visual Studio 14 => 15
build/common.props Outdated
| <PackageReference Include="Internal.AspNetCore.Sdk" Version="1.0.1-*" PrivateAssets="All" /> | ||
| </ItemGroup> | ||
| | ||
| <ItemGroup Condition="'$(TargetFrameworkIdentifier)'=='.NETFramework' AND '$(OutputType)'=='library'"> |
There was a problem hiding this comment.
This group can be removed because we never produce packages here for .NET Framework
pranavkm force-pushed the prkrishn/vs2017 branch from 4fc756f to be11363 Compare | 🆙 :date |
| (Assuming you're aware of the compile issues) |
| Also, just curious...doesn't affect approval.... Why was ActiviatorUtilities.cs renamed to DIActivatorUtilities? |
| We get a file name collision with the file imported as a content item from https://github.com/aspnet/Common/blob/dev/shared/Microsoft.Extensions.ActivatorUtilities.Sources/ActivatorUtilities.cs. Wasn't aware of the buidl error - I'll check. |
That shouldn't happen. Probably a bug on NuGet, but could be dotnet/sdk and the way they do default items. |
| Ok. I'll try and get a repro for it. |
No description provided.