made command-text clear after submitting

[rpiper2040]

just changed index.html in frontend and WebSerialWebPage.h in src

Summary by CodeRabbit

• New Features

  • The command input field now automatically clears after sending a command.

• Bug Fixes

  • Improved user experience by ensuring the input box resets after each command is sent.

[coderabbitai]

Walkthrough

The changes update the frontend's command input behavior and synchronize the embedded HTML data in the backend. The frontend now clears the command input field after sending a command via websocket. Correspondingly, the backend's embedded HTML byte array and its size constant have been updated to reflect the new HTML content. No other logic or public interface changes are present.

Changes

File(s)	Change Summary
frontend/index.html	Modified the sendCommand function to clear the input field after sending a command.
src/WebSerialWebPage.h	Updated WEBSERIAL_HTML_SIZE and replaced the WEBSERIAL_HTML byte array with new content.

Poem

A bunny taps the keys with cheer,
Now commands sent will disappear—
The box is cleared, the bytes refreshed,
HTML and input, both addressed!
With every hop, the code aligns,
In tidy fields and backend signs.
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/WebSerialWebPage.h (1)

5-83: Improve maintainability of embedded HTML.
Embedding the full gzipped HTML by hand is fragile. To keep the header in sync with frontend/index.html, you could:

• Add a build script (Makefile, Python, etc.) that gzips and converts index.html into this byte array automatically.
• Optionally include a verification step that decompresses the PROGMEM data and diffs it against the source HTML to catch mismatches early.

Let me know if you’d like assistance generating the embedding script.

frontend/index.html (1)

296-298: Enhance input handling after send.
To further streamline command entry and avoid accidental whitespace:

-function sendCommand() { - const input = document.getElementById("command-text"); - websocket.send(input.value); - input.value = ""; -} +function sendCommand() { + const input = document.getElementById("command-text"); + const cmd = input.value.trim(); + if (cmd) { + websocket.send(cmd); + input.value = ""; + input.focus(); + } +}

This trims leading/trailing spaces and returns focus to the text field for rapid successive commands.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0173415 and 3114815.

📒 Files selected for processing (2)

• frontend/index.html (1 hunks)
• src/WebSerialWebPage.h (1 hunks)

🔇 Additional comments (1)

frontend/index.html (1)

296-298: Clear input field after sending command.
The updated sendCommand function now retrieves the input element, sends its current value, and then resets it—clearly improving the UX by readying the field for the next entry.

[coderabbitai]

🛠️ Refactor suggestion

Automate HTML size constant.
Maintaining a manual WEBSERIAL_HTML_SIZE is error-prone and can easily drift out of sync with the actual array length. Consider computing it at compile time, for example:

const uint32_t WEBSERIAL_HTML_SIZE = sizeof(WEBSERIAL_HTML);

Or add a static_assert to validate the size matches the array:

static_assert(WEBSERIAL_HTML_SIZE == sizeof(WEBSERIAL_HTML), "HTML size mismatch");