Window/Aggregate function implementation -- please review

[Buggaboo]

So, I took one of sqlite3's sumint example to develop the window function, because I'm planning on using this codebase to develop other interesting window functions.

I'm not so super experienced with rust yet, so I would appreciate if you could give me some pointers.

I have two issues:

1. double free issue in test_sum_int.rs, I suspect my 'get_aggregate_context_value' somehow took ownership.
2. can't load the plugin: Error: dlsym(0x808c4010, sqlite3_sumint_init): symbol not found, I can't load the plugin, I might have missed something.

[asg017]

double free issue in test_sum_int.rs, I suspect my 'get_aggregate_context_value' somehow took ownership.

I'm not 100% sure, but x_final_wrapper and x_value_wrapper might need to reclaim the b box with Box::into_raw() , otherwise I think rust will drop it for you. Not too sure if it matter here, just saw it while skimming

can't load the plugin: Error: dlsym(0x808c4010, sqlite3_sumint_init): symbol not found, I can't load the plugin, I might have missed something.

On this line, change sqlite3_sum_int_init to sqlite3_sumint_init

sqlite-loadable-rs/examples/sum_int.rs

Line 42 in f0eca51

pub fn sqlite3_sum_int_init(db: *mut sqlite3) -> Result<()> {

Also, sorry if this was your first foray into Rust - this codebase isn't that great, and Rust <-> C FFI is never fun!

On the other hand, this might inspire me to get proper aggregate/window support is this project...

[Buggaboo]

Hi,

This is ready for review. I checked with valgrind, the new sumint example has no detectable leaks.