- Notifications
You must be signed in to change notification settings - Fork 267
Refactor(eos_designs): Move platform_settings.validate_hardware to validation_profiles #6258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
…lidation_profiles
| Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory python -m venv test-avd-pr-6258 # Activate the virtual environment source test-avd-pr-6258/bin/activate # Install all requirements including PyAVD pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-6243#subdirectory=python-avd" --force # Point Ansible collections path to the Python virtual environment export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections # Install Ansible collection ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-6243 --force # Optional: Install AVD examples cd test-avd-pr-6258 ansible-playbook arista.avd.install_examples |
| This pull request has conflicts, please resolve those before we can evaluate the pull request. |
| Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/validation_profiles.schema.yml Show resolved Hide resolved
Shivani-gslab left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../avd/extensions/molecule/eos_designs_unit_tests/intended/structured_configs/7010TX-LEAF1.yml Show resolved Hide resolved
|



Change Summary
Move platform_settings.validate_hardware to validation_profiles
Related Issue(s)
Fixes #6243
Component(s) name
arista.avd.eos_designsProposed changes
One key will go under features
Make it default false for cEOS and vEOS like it is today
How to test
Run molecule
Checklist
User Checklist
Repository Checklist