Skip to content

Conversation

@MaheshGSLAB
Copy link
Contributor

Change Summary

Move platform_settings.validate_hardware to validation_profiles

Related Issue(s)

Fixes #6243

Component(s) name

arista.avd.eos_designs

Proposed changes

One key will go under features

platform_settings: feature_support: # Enable hardware validation for the device. # If `false`, all hardware tests are skipped, therefore the other keys in `validate_hardware` are ignored. hardware_validation: <bool; default=True> 

Make it default false for cEOS and vEOS like it is today

validation_profiles: name: <str, primary_key> # Max one level of inheritance parent_profile: <str> # Only considered when `platform_settings.feature_support.hardware_validation: true` hardware: # Minimum number of power supplies required for the device. Set to 0 to skip validation. min_power_supplies: <int> # Minimum number of fans required for the device. Set to 0 to skip validation. min_fans: <int> # Minimum number of supervisor modules required for the device. Set to 0 to skip validation. min_supervisors: <int> # Minimum number of line cards required for the device. Set to 0 to skip validation. min_line_cards: <int> # Minimum number of fabric cards required for the device. Set to 0 to skip validation. min_fabric_cards: <int> # List of approved transceiver manufacturers for the device. transceiver_manufacturers: logging: # Threshold (in minutes) defining how far back to check the logging buffer for error-level logs during the validation performed by the `anta_runner` role. validate_no_errors_period: <int> # Exclude this node from being used as a destination target from other fabric devices in the extra fabric validation tests performed by the `anta_runner` role. exclude_as_extra_fabric_validation_target: <bool; default=False> and under node_type_settings 
l3leaf: nodes: - name: <str> validation_profile: <str> 

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)
@MaheshGSLAB MaheshGSLAB self-assigned this Dec 16, 2025
@github-actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory python -m venv test-avd-pr-6258 # Activate the virtual environment source test-avd-pr-6258/bin/activate # Install all requirements including PyAVD pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-6243#subdirectory=python-avd" --force # Point Ansible collections path to the Python virtual environment export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections # Install Ansible collection ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-6243 --force # Optional: Install AVD examples cd test-avd-pr-6258 ansible-playbook arista.avd.install_examples
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 16, 2025
@MaheshGSLAB MaheshGSLAB changed the title Refactor(eos_designs): Move platform_settings.validate_hardware to validation_profiles (WIP) Refactor(eos_designs): Move platform_settings.validate_hardware to validation_profiles Dec 16, 2025
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 17, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 18, 2025
@gmuloc gmuloc requested a review from Shivani-gslab December 18, 2025 13:23
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review December 19, 2025 06:49
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners December 19, 2025 06:49
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated

3 participants