Allow specifying the path when adding a repository #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There's many cases where adding repositories inconditionally to `sources.list.d/managed.list` is not ideal: it's very common to add an entry per file, ideally named after the repository to add. Configuration management tools for instance follow that pattern. It's also more consistent with other operations not enforcing having a single file for all entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There's many cases where adding repositories inconditionally to
sources.list.d/managed.listis not ideal: it's very common to add an entry per file, ideally named after the repository to add. Configuration management tools for instance follow that pattern. It's also more consistent with other operations not enforcing having a single file for all entries.Note that while this is a breaking change in the API, I haven't noticed any release of this repository so far, which I take to mean that having such breaking change is alright. If not, I can introduce a new function instead.