Skip to content

Conversation

mcmchris
Copy link
Collaborator

@mcmchris mcmchris commented Jan 8, 2023

What This PR Changes

  • Declaring the namespace as follows: "using namespace nicla;" doesn't work in the Arduino IDE, so it's necessary to name it before each statement (ex. nicla::leds.setColor(red);).

Please test this by yourself and let me know if it works for you. I tested it on IDE 2.0.3 and 1.8.19

Contribution Guidelines

Declaring the namespace as follows: "using namespace nicla;" doesn't work in the Arduino IDE, so it's necessary to name it before each statement (ex. nicla::leds.setColor(red);). Please test this by yourself and let me know if it works for you. I tested it on IDE 2.0.3 and 1.8.19
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2023

CLA assistant check
All committers have signed the CLA.

@sebromero
Copy link
Contributor

@mcmchris Well spotted! There was a breaking change in a core release that fell through the cracks in the documentation. Thank you!

@sebromero
Copy link
Contributor

@mcmchris Can you sign the CLA so we can merge this?

@mcmchris
Copy link
Collaborator Author

mcmchris commented Feb 9, 2023

@mcmchris Can you sign the CLA so we can merge this?

Done!

Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebromero sebromero merged commit ec93fdf into arduino:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants