[PC-971] benjamindannegard/Added-connectivty-tutorial-for-Opta #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ docs-content deploy preview ready
|
BenjaminDannegard changed the title 
TaddyHC reviewed Dec 21, 2022
There was a problem hiding this comment.
I have made some changes directly within the content. Most of them were to address typos and phrasings. Mainly Modbus TCP via Ethernet Port's section content have been corrected as it was mixing some concepts. Additionally, I found that some phrasings of the same Modbus section are from a different source, it would be great to see if it can be referenced. Please have a look at the updated content. 👍
jcarolinares requested review from TaddyHC and marqdevx and removed request for jcarolinares TaddyHC reviewed Dec 22, 2022
There was a problem hiding this comment.
I have made some changes directly within the content. Most of them were to address typos and phrasings. Mainly Modbus TCP via Ethernet Port's section content have been corrected as it was mixing some concepts. Additionally, I found that some phrasings of the same Modbus section are from a different source, it would be great to see if it can be referenced. Please have a look at the updated content. 👍
I have made direct changes previously as in the comment. But due to new naming rule for Arduino Opta®, I have made new suggestions now including in regard of trademark rule. Please have a look on these suggestions.
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
...e/05.pro-solutions/solutions-and-kits/opta/tutorials/getting-started-connectivity/content.md Outdated Show resolved Hide resolved
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
…rials/getting-started-connectivity/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
jcarolinares approved these changes Dec 22, 2022
jcarolinares requested changes Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines