Skip to content

[TC-346] MKR WiFi 1010 App Note #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Feb 13, 2023
Merged

[TC-346] MKR WiFi 1010 App Note #485

merged 27 commits into from
Feb 13, 2023

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Aug 19, 2022 •
edited
Loading

What This PR Changes

  • Add application note for connecting a LiPo battery to the MKR boards (MKR WiFi 1010)

Contribution Guidelines
@aliphys aliphys added documentation Improvements or additions to documentation Tutorial labels Aug 19, 2022
@aliphys aliphys requested a review from karlsoderby August 19, 2022 08:57
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 19, 2022 •
edited
Loading

✅ docs-content deploy preview ready
@karlsoderby
Copy link
Contributor

Hey @aliphys is there anything needed to go live with this article?
@aliphys
Copy link
Contributor Author

aliphys commented Sep 8, 2022

Hey @aliphys is there anything needed to go live with this article?

Other people have also reported issues with MathJax and Gatsby e.g. gatsbyjs/gatsby#16983
For this task, I'll render images, and upload them instead.
@aliphys aliphys requested a review from karlsoderby September 12, 2022 11:21
karlsoderby
karlsoderby previously requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @aliphys . Left some comments that needs to be addressed before merging.
@aliphys aliphys force-pushed the aliphys/mkrBatteryAppNote2 branch from fd5e2e0 to 6212e8e Compare September 22, 2022 08:32
@karlsoderby
Copy link
Contributor

Hey @aliphys you will need to rebase this PR because of a gatsby issue we had last week. Also there are some small issues to fix with the spellcheck and content linter checks.
@aliphys
Copy link
Contributor Author

aliphys commented Sep 27, 2022

@karlsoderby So I should rebase it again?
@karlsoderby
Copy link
Contributor

@aliphys Ah I see that you did that now! I saw that gatsby fail and I assumed it was due to that issue. I re-ran the check now so hopefully it works :)
@aliphys aliphys mentioned this pull request Oct 12, 2022
Closed
1 task
@aliphys
Copy link
Contributor Author

aliphys commented Nov 17, 2022

Current PR branch superseeds the previous (https://github.com/arduino/docs-content/tree/aliphys/mkrBatteryAppNote ) branch, hence it is deleted
aliphys and others added 18 commits February 9, 2023 14:16
@aliphys
title case
c9ebfb4
@aliphys
Remove unused asset
cdde2d8
@aliphys
More writing
6743632
@aliphys
More changes
5ad6540
@aliphys
Add images
93ba726
@aliphys
More edits
ef6bac4
@aliphys
Remove unused asset
5dd2fdf
@aliphys
Change math symbol from $$ to \[\]
bb43fef
@aliphys
Replace Tex with Figma images
044ad00
@aliphys @karlsoderby
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
883f74b 
…battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@aliphys
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
d84803d 
…battery-app-note/mkr-battery-app-note.md
@aliphys @karlsoderby
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
5337150 
…battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@aliphys @karlsoderby
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
9988f29 
…battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@aliphys @karlsoderby
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
7840308 
…battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@aliphys @karlsoderby
Update content/hardware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-…
786a6c8 
…battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@aliphys
Correct 'variant' spelling
12abbf4
@aliphys
remove rebase residue
fec1ef8
@aliphys
Change Li-ion to Li-Ion to make linter happy
9abbe34
@aliphys aliphys force-pushed the aliphys/mkrBatteryAppNote2 branch from 9b42c23 to 9abbe34 Compare February 9, 2023 13:51
@aliphys aliphys requested a review from karlsoderby February 9, 2023 14:10
@aliphys
Copy link
Contributor Author

aliphys commented Feb 9, 2023 •
edited
Loading

@karlsoderby can we merge this app note now? :)
@aliphys
Copy link
Contributor Author

aliphys commented Feb 9, 2023

Gatsby building now working, re-based branch and now up to date 🎉
marqdevx
marqdevx approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@marqdevx marqdevx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I did not review
@aliphys aliphys merged commit ba71fc9 into main Feb 13, 2023
@aliphys aliphys deleted the aliphys/mkrBatteryAppNote2 branch February 13, 2023 15:04
Serjlee pushed a commit that referenced this pull request Sep 28, 2023
@BenjaminDannegard
Merge pull request #485 from arduino/benjamindannegard/giga-display-s…
3deb0b0 
…hield-launch-branch GIGA display shield datasheet update from launch branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Tutorial

3 participants

@aliphys @karlsoderby @marqdevx