Skip to content

Conversation

Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR adds a Bluetooth® Low Energy Learn Article.

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 26, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, now it's @kateryna-lukina's turn!

Copy link
Member

@kateryna-lukina kateryna-lukina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, good job 🙌

@karlsoderby karlsoderby self-requested a review September 27, 2023 09:19
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Hannes7eicher , some feedback regarding this article:

  • At the moment it explains what Bluetooth is very well, but does not focus much on how it actually works with an Arduino board.
  • It switches focus at the Arduino BLE Library section, but this is actually the start of a tutorial for how to use BLE with the MKR WiFi 1010. I think here the rework is needed so that it works on any device, including UNO R4 WiFi, Nano BLE, etc etc.
  • The Arduino BLE Library section should not be very long, it should introduce the library briefly, link to the library, and link to the repository.
  • There is no section that lists out the compatible boards. This should be at the top of the article. See this article for inspiration.
  • Instructions are showing how to install a library using the Arduino IDE 1. I don't think we need to show how to install a library (we got some feedback on this recently), but if necessary, we should at least show the IDE 2, or link to the "install library" article.
  • The last for sections Arduino BLE Library, Complete Code, Testing it Out & Conclusion are essentially linked together but in a guide like this it does not work. Each section should be more "standalone". In this case, I would rather see a single example per section. Like this:

Control LED Example

Short description, just a paragraph.

code example 

Expected outcome, again just paragraph, maybe a photo/gif/screenshot of terminal.

Another Example (maybe streaming sensor data?)

...


@Hannes7eicher Hannes7eicher marked this pull request as draft September 27, 2023 09:54
@Hannes7eicher Hannes7eicher marked this pull request as ready for review October 3, 2023 13:32
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Hannes7eicher , left some suggestions and a comment about adding a circuit. Great work!

Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
Hannes7eicher and others added 2 commits October 18, 2023 14:03
Co-authored-by: Jacob Hylén <60390259+jacobhylen@users.noreply.github.com>
@karlsoderby karlsoderby merged commit 3cdfca4 into main Oct 20, 2023
@karlsoderby karlsoderby deleted the Hannes7eicher/Bluetooth-Learn-Article branch October 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants