Skip to content

Conversation

@Hannes7eicher
Copy link
Contributor

What This PR Changes

This PR:

  • updates the ESP32 Getting Started Guide
  • adds missing frontmatter

Contribution Guidelines

@jacobhylen jacobhylen self-requested a review August 11, 2023 09:16
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 11, 2023

✅ docs-content deploy preview ready

Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots are very small, can we zoom into them with callout highlights instead?

Also make your IDE window smaller when taking the screenshots, the text is very difficult to read.

@jacobhylen
Copy link
Contributor

wifi-connected @Hannes7eicher Can we change the screenshots to something like this? I still think they are very small.
Copy link
Contributor

@jacobhylen jacobhylen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one last comment. :)

…tarted-nano-esp32/getting-started-nano-esp32.md Co-authored-by: Jacob Hylén <60390259+jacobhylen@users.noreply.github.com>
@Hannes7eicher Hannes7eicher merged commit c07139a into main Aug 18, 2023
@Hannes7eicher Hannes7eicher deleted the Hannes7eicher/ESP32-Getting-Started-Update branch August 18, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants