Skip to content

#1431 Add missing translations #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

#1431 Add missing translations #1449

merged 1 commit into from
Sep 26, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 16, 2022 •
edited
Loading

Motivation

Add the missing translations.

Was fixed:

  • File > Save and File > Save As..:
    Screen Shot 2022-09-19 at 13 40 47

  • Edit, Edit > Copy, and Edit > Paste:
    Screen Shot 2022-09-19 at 13 41 14

  • Help menu:
    Screen Shot 2022-09-19 at 13 48 18

  • Search in workspace: Replace, files to include, and files to exclude labels and all Match Case, Match Whole Word, etc tooltips:

    siw.mp4

  • Tooltips for the Terminal:
    Screen Shot 2022-09-19 at 13 46 49

  • Install/Uninstall in the library/boards manager:

    install_uninstall.mp4

  • Tools > Serial ports and Tools > Network ports (no translations yet):

  • Settings > Network > Manual Proxy Configuration (no translations yet):

  • Boards, Ports, and Show all ports in the board select dialog (no translations yet):

  • Couldn't open serial plotter (no translations yet):

  • Translated compiler warnings in Settings dialog: All, None, Default, and More (no translations yet):

  • Find/Replace widget in editors + all Monaco-based language contributions:
    Screen Shot 2022-09-19 at 17 02 27

Language pack changes:

  • Downgraded the following language packs to 1.53.2:
    • French (fr),
    • Chinese (Simplified) (zh-hans),
    • German (de),
    • Japanese (ja),
    • Turkish (tr),
    • Italian (it),
    • Russian (ru),
    • Spanish (es),
    • Portuguese (Brazil) (pt-BR), and
    • Czech (cs).
  • Added the following language packs:
    • Hungarian (hu) [1.48.3],
    • Bulgarian (bg) [1.48.3],
    • Polish (id) [1.53.2],
    • Ukrainian (uk) [1.48.3], and
    • Korean (ko) [1.53.2].

WONT FIX:

Context menu item in view containers, such as Debug view:
Screen Shot 2022-09-14 at 17 29 03

Change description

Other information

Closes #1431

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 16, 2022
@kittaakos
Copy link
Contributor Author

@per1234, any ideas on how we can verify these changes? Translations won't be available by the time the review happens. So we cannot verify that it works. Thank you!
This was referenced Sep 17, 2022
Closed
Open
@kittaakos kittaakos force-pushed the #1431 branch 3 times, most recently from 8eddd1f to af6ceb8 Compare September 19, 2022 13:26
@kittaakos kittaakos marked this pull request as ready for review September 19, 2022 15:06
AlbyIanna
AlbyIanna approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me ✅
@kittaakos
Copy link
Contributor Author

This PR should contain #1462.
per1234
per1234 requested changes Sep 22, 2022
View reviewed changes
Fixed missing translations
fdd6217 
Aligned the languge pack versions. Closes arduino#1431 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
per1234
per1234 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved code changes and behaviour. Thanks Akos!
@kittaakos kittaakos merged commit 9ef04bb into arduino:main Sep 26, 2022
@per1234 per1234 linked an issue Sep 26, 2022 that may be closed by this pull request
Add missing localization for locales with available language pack #712
Open
3 tasks
This was referenced Sep 26, 2022
Open
Merged
@per1234 per1234 mentioned this pull request Oct 11, 2022
Closed
3 tasks
@kittaakos kittaakos mentioned this pull request May 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
3 participants
@kittaakos @AlbyIanna @per1234