change reset function

arduino-ide-extension/src/browser/contributions/settings.ts

@@ -32,7 +32,7 @@ export class Settings extends SketchContribution {
  await this.settingsService.update(settings);
  await this.settingsService.save();
  } else {
- await this.settingsService.reset(true);
+ await this.settingsService.resetFromDialog();
  }
  },
  isEnabled: () => !this.settingsOpened,

arduino-ide-extension/src/browser/dialogs/settings/settings-dialog.tsx

@@ -114,7 +114,7 @@ export class SettingsDialog extends AbstractDialog<Promise<Settings>> {
 
  // calling settingsService.reset() in order to reload the settings from the preferenceService
  // and update the UI including changes triggered from the command palette
- this.settingsService.reset(false);
+ this.settingsService.reset();
 
  this.widget.activate();
  }

arduino-ide-extension/src/browser/dialogs/settings/settings.ts

@@ -208,14 +208,18 @@ export class SettingsService {
  }
  }
 
- async reset(resetFromDialog: boolean): Promise<void> {
- const prevThemeId = this._settings.prevThemeId;
+ async reset(): Promise<void> {
  const settings = await this.loadSettings();
  await this.update(settings, false);
  this.onDidResetEmitter.fire(this._settings);
- if (resetFromDialog && prevThemeId) {
+ }
+
+ async resetFromDialog(): Promise<void> {
+ const prevThemeId = this._settings.prevThemeId;
+ if (prevThemeId) {
  ThemeService.get().setCurrentTheme(prevThemeId);
  }
+ this.reset();
  }
 
  async validate(