Skip to content

Output panel optimisation #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Output panel optimisation #1058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c56008
test interval for output panel
davegarthsimpson Jun 13, 2022
d567109
create buffer provider
davegarthsimpson Jun 13, 2022
ac7fc00
output panel buffer corrections
davegarthsimpson Jun 13, 2022
085f97e
output buffer cleanup
davegarthsimpson Jun 14, 2022
1b16101
code cleanup
davegarthsimpson Jun 14, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
output panel buffer corrections
  • Loading branch information
@davegarthsimpson
davegarthsimpson committed Jun 13, 2022
commit ac7fc000432bea25f88cda3cc2b03ec6bc8ba4b9
9 changes: 3 additions & 6 deletions arduino-ide-extension/src/node/core-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
const result = client.compile(compileReq);

const compileBuffer = new OutputPanelBufferProvider(
this.flushOutputPanelMessages,
this.flushOutputPanelMessages.bind(this),
this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
);
try {
Expand Down Expand Up @@ -185,7 +185,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
const result = responseHandler(client, req);

const uploadBuffer = new OutputPanelBufferProvider(
this.flushOutputPanelMessages,
this.flushOutputPanelMessages.bind(this),
this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
);
try {
Expand Down Expand Up @@ -256,7 +256,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
const result = client.burnBootloader(burnReq);

const bootloaderBuffer = new OutputPanelBufferProvider(
this.flushOutputPanelMessages,
this.flushOutputPanelMessages.bind(this),
this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
);
try {
Expand Down Expand Up @@ -309,8 +309,5 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
this.responseService.appendToOutput({
chunk,
});
this.responseService.appendToOutput({
chunk,
});
}
}
9 changes: 6 additions & 3 deletions arduino-ide-extension/src/node/output-panel-buffer-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ export class OutputPanelBufferProvider {

constructor(onFlush: (chunk: string) => void, flushTimeout: number) {
this.flushInterval = setInterval(() => {
const chunkString = Buffer.concat(this.chunks).toString();
onFlush(chunkString);
this.clearChunks();
if (this.chunks.length > 0) {
const chunkString = Buffer.concat(this.chunks).toString();
this.clearChunks();

onFlush(chunkString);
}
}, flushTimeout);
}

Expand Down