Skip to content

Better gRPC error handling #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 30, 2021
Merged

Better gRPC error handling #1251

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b7e8ff4
Proper gRPC error handling
cmaglie Feb 10, 2021
b6522c0
Update gRPC API of board command to return status.Status instead of e…
per1234 Jun 25, 2021
67c19f2
Update gRPC API of remaining commands to return status.Status instead…
per1234 Jun 30, 2021
17652b6
Replace custom error with protobuf message
per1234 Jul 9, 2021
c6b72b9
Handle details of any type in `core.PlatformUpgrade()` status
per1234 Jul 9, 2021
4696d07
Return nil on program action if an error occurred
cmaglie Jul 13, 2021
acf791e
Refactoring 'upload' commands
cmaglie Aug 25, 2021
4fa1080
Refactoring 'board' commands
cmaglie Aug 25, 2021
ce3f802
Refactoring 'compile' commands
cmaglie Aug 25, 2021
5890cb2
Refactoring 'core' commands
cmaglie Aug 26, 2021
0195111
Refactoring 'debug' commands
cmaglie Aug 26, 2021
1025981
Refactoring 'lib' commands
cmaglie Aug 26, 2021
1e770ca
Refactoring 'sketch' commands
cmaglie Aug 26, 2021
677fd55
Refactoring 'commands' commands
cmaglie Aug 27, 2021
763fcb8
updated tests and fixed some error wording
cmaglie Aug 27, 2021
50d17c4
fixed go lint warnings
cmaglie Aug 27, 2021
89a61df
Apply suggestions from code review
cmaglie Aug 28, 2021
4bcaf9c
Apply changes from code review
cmaglie Aug 30, 2021
6bf77b9
fix i18n
cmaglie Aug 27, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return nil on program action if an error occurred
  • Loading branch information
@cmaglie
cmaglie committed Aug 28, 2021
commit 4696d0787711491545e365202b0328e9c1a5afb0
8 changes: 6 additions & 2 deletions commands/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er

pm := commands.GetPackageManager(req.GetInstance().GetId())

return &rpc.UploadResponse{}, runProgramAction(
if err := runProgramAction(
pm,
sk,
req.GetImportFile(),
Expand All @@ -142,7 +142,11 @@ func Upload(ctx context.Context, req *rpc.UploadRequest, outStream io.Writer, er
errStream,
req.GetDryRun(),
req.GetUserFields(),
)
); err != nil {
return nil, err
}

return &rpc.UploadResponse{}, nil
}

// UsingProgrammer FIXMEDOC
Expand Down