Skip to content

Conversation

apetenchea
Copy link
Member

While I was working on the async driver, I noticed a few things in the collections code:

  1. The truncate method was missing some parameters: ca09add
  2. The overwrite parameter was unused by update: d5ae65d
  3. Some docstrings have been adjusted: f27348d and 5bdc7a5 (batch execution is no longer supported)
@apetenchea apetenchea requested a review from aMahanna March 27, 2025 05:02
@apetenchea apetenchea self-assigned this Mar 27, 2025
Copy link
Member

@aMahanna aMahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 2 small comments

apetenchea and others added 2 commits March 28, 2025 10:27
Co-authored-by: Anthony Mahanna <43019056+aMahanna@users.noreply.github.com>
Co-authored-by: Anthony Mahanna <43019056+aMahanna@users.noreply.github.com>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (8e6aaca) to head (8c3fc80).
Report is 14 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (8e6aaca) and HEAD (8c3fc80). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8e6aaca) HEAD (8c3fc80)
3 1
Additional details and impacted files
@@ Coverage Diff @@ ## main #367 +/- ## =========================================== - Coverage 95.94% 83.36% -12.59%  =========================================== Files 26 26 Lines 4296 4303 +7 =========================================== - Hits 4122 3587 -535  - Misses 174 716 +542 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@apetenchea apetenchea merged commit 173f2b3 into main Mar 28, 2025
37 checks passed
@apetenchea apetenchea deleted the chore/collection-maintenance branch March 28, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants