Skip to content

Computed Values support for PUT /_api/collection/collection/properties #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Computed Values support for PUT /_api/collection/collection/properties #268

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b70f49
initial commit
aMahanna Aug 8, 2023
44bd495
fix: black
aMahanna Aug 8, 2023
26083c5
fix: prevent computedValue from affecting other tests
aMahanna Aug 8, 2023
5bd3843
typing: Jsons instead of List[Json]
aMahanna Aug 8, 2023
0d7c42c
fix: isort
aMahanna Aug 8, 2023
3acd627
update: computedValues formatter
aMahanna Aug 9, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: prevent computedValue from affecting other tests
  • Loading branch information
@aMahanna
aMahanna committed Aug 8, 2023
commit 26083c57da75104d2f33f16e4bf62e5749af0c28
2 changes: 2 additions & 0 deletions tests/test_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def test_collection_misc_methods(col, bad_col, cluster):
assert properties["system"] is False
assert properties["sync"] is not prev_sync
assert properties["computedValues"] == computed_values
col.configure(computed_values=[])

# Test configure properties with bad collection
with assert_raises(CollectionConfigureError) as err:
Expand Down Expand Up @@ -210,6 +211,7 @@ def test_collection_management(db, bad_db, cluster):
assert properties["sync"] is True
assert properties["system"] is False
assert properties["computedValues"] == computed_values
col.configure(computed_values=[])

# Test create duplicate collection
with assert_raises(CollectionCreateError) as err:
Expand Down