Skip to content

Fixes view links format #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fixes view links format #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion arango/formatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,7 +811,9 @@ def format_view(body): # pragma: no cover
if 'writebufferSizeMax' in body:
result['writebuffer_max_size'] = body['writebufferSizeMax']
if 'links' in body:
result['links'] = [format_view_link(link) for link in body['links']]
result['links'] = {
name: format_view_link(link) for name, link in body['links'].items()
}

return verify_format(body, result)

Expand Down
11 changes: 9 additions & 2 deletions tests/test_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
ViewReplaceError,
ViewUpdateError
)
from tests.helpers import assert_raises, generate_view_name
from tests.helpers import assert_raises, generate_view_name, generate_col_name


def test_view_management(db, bad_db, cluster):
Expand All @@ -18,15 +18,22 @@ def test_view_management(db, bad_db, cluster):
bad_view_name = generate_view_name()
view_type = 'arangosearch'

col_name = generate_col_name()
col = db.create_collection(
name=col_name
)

result = db.create_view(
view_name,
view_type,
{'consolidationIntervalMsec': 50000}
{'consolidationIntervalMsec': 50000, "links": {col_name: {}}}
)
assert 'id' in result
assert result['name'] == view_name
assert result['type'] == view_type
assert result['consolidation_interval_msec'] == 50000
assert col_name in result["links"]

view_id = result['id']

# Test create duplicate view
Expand Down