[Feature] Define OptionalReplace Upgrade Mode option #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new upgrade mode called "optional-replace" for ArangoDB deployment server groups. This mode provides a conditional replacement strategy that falls back to replacing members when upgrades fail with specific exit codes, particularly code 30 for compaction failures.
- Adds the "optional-replace" upgrade mode as a new enum value across all API versions
- Updates validation logic to accept the new upgrade mode
- Documents the new mode in API specifications and user documentation
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/crd/crds/database-deployment.schema.generated.yaml | Adds "optional-replace" enum value to all upgrade mode definitions in CRD schema |
| pkg/apis/deployment/v2alpha1/server_group_spec_upgrade_mode.go | Defines the new constant and updates validation logic for v2alpha1 |
| pkg/apis/deployment/v1/server_group_spec_upgrade_mode.go | Defines the new constant and updates validation logic for v1 |
| pkg/apis/deployment/v2alpha1/server_group_spec.go | Adds documentation for the new upgrade mode in v2alpha1 spec |
| pkg/apis/deployment/v1/server_group_spec.go | Adds documentation for the new upgrade mode in v1 spec |
| docs/api/ArangoDeployment.V1.md | Updates API documentation to include the new upgrade mode option |
| CHANGELOG.md | Records the feature addition in the changelog |
jwierzbo approved these changes Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.