Skip to content

Conversation

ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Jul 1, 2025

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 1, 2025
@ajanikow ajanikow requested a review from Copilot July 1, 2025 09:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the default behavior for the SchedulerV2 Wait flag from true to false, aligning the configuration with updated platform expectations.

  • Reverts the default Wait value in both installation and upgrade options.
  • Updates the CHANGELOG to reflect the reversion of SchedulerV2 defaults.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
integrations/scheduler/v2/definition/helpers.go Reverts the Wait flag default in both Install and Upgrade options.
CHANGELOG.md Updates changelog entry to document the SchedulerV2 Defaults Revert.
Comments suppressed due to low confidence (3)

integrations/scheduler/v2/definition/helpers.go:94

  • The default value for the Wait flag has been changed from true to false. Please ensure that this change aligns with the intended API behavior and that related tests and documentation are updated accordingly.
in.Wait = util.OptionalType(i.Wait, false) 

integrations/scheduler/v2/definition/helpers.go:111

  • The Wait flag's default value has been reverted to false in the Upgrade options as well. Confirm that this change is intentional and that the behavior is consistently documented and tested.
in.Wait = util.OptionalType(i.Wait, false) 

CHANGELOG.md:10

  • [nitpick] Consider expanding the changelog entry with additional detail about the implications of reverting the SchedulerV2 Wait default value to false for clarity to the users.
- (Feature) (Platform) SchedulerV2 Defaults Revert 
@ajanikow ajanikow force-pushed the feature/platform/defaults_revert branch from 10473f9 to 2b1b457 Compare July 1, 2025 09:32
@ajanikow ajanikow merged commit 298f1b9 into master Jul 1, 2025
3 checks passed
@ajanikow ajanikow deleted the feature/platform/defaults_revert branch July 1, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants