[Feature] [Platform] Service Loop

[ajanikow]

No description provided.

[Copilot]

Pull Request Overview

This PR introduces changes for the Platform Service Loop feature by improving Helm release management, finalizer handling, and integration tests while updating utility functions to use standard library alternatives. Key changes include:

• Enhancements in finalizer handling and release operations in the platform service handler.
• Updates to CRD application logic and utility functions (e.g., using slices.Contains).
• Extensive modifications to integration and scheduler tests for improved release status and installation workflows.

Reviewed Changes

Copilot reviewed 65 out of 68 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/handlers/platform/service/handler.go	Adds finalizer logic and helm uninstall handling for service deletion.
pkg/crd/apply.go	Updates CRD application to use executor.Run and slices.Contains for skip logic.
integrations/scheduler/v2/definition/helpers.go	Adjusts default wait option for install/upgrade requests in helm operations.
integrations/scheduler/v2/helm.go	Introduces explicit nil release checks returning NotFound errors.
integrations/scheduler/v2/implementation_test.go	Refines tests expectations regarding helm release values and uninstallation.

Comments suppressed due to low confidence (3)

integrations/scheduler/v2/definition/helpers.go:94

• [nitpick] Updating the default 'Wait' flag from false to true may increase blocking time during Helm operations; please ensure that this change aligns with the intended deployment responsiveness.

in.Wait = util.OptionalType(i.Wait, true) 

integrations/scheduler/v2/helm.go:96

• Returning a NotFound error when the Helm release is nil provides explicit feedback; ensure that this behavior is consistently documented and integrated with API consumers.

if resp == nil { 

integrations/scheduler/v2/implementation_test.go:197

• [nitpick] The expected length of release values was adjusted from 4 to 0. Please confirm that this change is intentional and update the test description if necessary to reflect the new behavior.

require.Len(t, status.GetRelease().GetValues(), 0)