Feature/stream tx graph #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hkernbach approved these changes Sep 3, 2019
hkernbach reviewed Sep 3, 2019
| @Test | ||
| public void getVertex() { | ||
| assumeTrue(isSingleServer()); | ||
| assumeTrue(isAtLeastVersion(3, 5)); |
There was a problem hiding this comment.
Oh, one thing:
assumeTrue(isAtLeastVersion(3, 5));
^-- does this needs to be instead isAtLeastVersion(3,5,1) ?
There was a problem hiding this comment.
We are still discussing about which db versions to support and to test against... For the moment we only support and test against the latest patch of every minor release. Eg. atm 3.3.23, 3.4.8 and 3.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
stream tx support in graph vertex/edge operations at /_api/gharial