Skip to content

Conversation

@czechboy0
Copy link
Contributor

Motivation

Implements the approved SOAR-0002 proposal: #170

Modifications

  • updates the function that computes content type names to be in line with v3 of SOAR-0002
  • refactors the ContentType type a bit to make it harder to accidentally perform case-sensitive comparions where case-insensitive ones are required

Result

When an adopter passes the multipleContentTypes feature flag, they'll get the new logic as described in SOAR-0002.

Test Plan

  • adapted unit tests for the contentSwiftName function
  • enabled the proposal0001 feature flag as well, since they will be enabled together in 0.2.0, so makes sense to test the new world together
  • this lead to a few more updates needed in the reference tests that weren't caused by 0.2.0 alone
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czechboy0 czechboy0 merged commit abcc8bb into apple:main Aug 14, 2023
@czechboy0 czechboy0 deleted the hd-soar-0002-impl branch August 14, 2023 12:36
@czechboy0 czechboy0 added the 🔨 semver/patch No public API change. label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 semver/patch No public API change.

2 participants