[Bugfix] Finalize diagnostics even when an error is thrown #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, when the generation logic threw an error, we wouldn't finalize the diagnostics collector, which in the case of the YAML file diagnostics collector meant the file would never be written, and the caller wouldn't know why the tool returned a non-0 exit code.
Modifications
Move the finalization into every logic branch, to make sure it's always called at the end.
Result
Now when providing
--diagnostics-output-pathto the CLI and the generation fails with an error, the diagnostics YAML file will be written correctly.Test Plan
Tested manually locally using another script that drives
swift-openapi-generator.